Closed
Conversation
- Add Nushell variant to Shell enum with config paths and detection - Create nushell.nu template with --env flag for cd directive handling - Add nushell to default shells in install/uninstall commands - Update completion format to support nushell descriptions - Add nushell installation to CI workflows - Document nushell setup in shell integration docs
Nushell is not available in apt repositories. Use the official GitHub Action for installing nushell on Linux and macOS.
Add integration tests for nushell shell support:
Template fixes (templates/nushell.nu):
- Use mktemp --tmpdir to avoid polluting the git repo
- Use $env.LAST_EXIT_CODE for real-time output streaming
- Fix path parsing (str substring 4..-2) to strip quotes
- Add multi-line directive support for --execute commands
Test infrastructure (tests/integration_tests/shell_wrapper.rs):
- Add nushell env syntax ($env.VAR) in build_shell_script()
- Add --no-config-file flag in exec_in_pty_interactive()
- Add #[case("nu")] to 11 parameterized tests
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Owner
OK, very respectfully, and I appreciate your attempt — but then this isn't that useful. You don't need to be an excellent rust coder at all (I'm not sure I'm an excellent rust coder...), but https://simonwillison.net/2025/Dec/18/code-proven-to-work/ summarizes it well |
Contributor
Author
|
@MattiasMTS no worries, I'll look at it further. In retrospect I pushed this too fast :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based of #535 with additional tests.
This is coded via claude as I don't know rust. I'm not sure about the quality of the work.