Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds WebAssembly (wasm) support to the button-driver crate by refactoring the JavaScript-based instant provider and removing the std dependency requirement for wasm targets.
- Refactored
JsInstantinto a nestedinstant::wasm::Instantmodule for better organization - Removed
stdrequirement from thewasmfeature, enablingno_stdwasm usage - Updated the wasm example to use the new module path
- Consolidated CI clippy checks for improved workflow efficiency
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Removed obsolete public export of JsInstant |
| src/instant.rs | Moved wasm instant provider into wasm module and renamed type from JsInstant to Instant |
| examples/wasm/src/lib.rs | Updated to use new instant::wasm::Instant path and added formatting improvements |
| examples/wasm/Cargo.lock | Updated dependency versions (wasm-bindgen, js-sys, etc.) |
| examples/stm32/Cargo.lock | Updated button-driver version to 0.2.4 and other dependency versions |
| examples/stm32-embassy/Cargo.lock | Updated button-driver version to 0.2.4 and other dependency versions |
| README.md | Added wasm to list of supported targets and updated example instructions |
| Cargo.toml | Bumped version to 0.2.5, removed std requirement from wasm feature, added default-features = false to js-sys, expanded docs.rs features |
| .vscode/settings.json | Added multiple features to rust-analyzer configuration |
| .github/workflows/rust.yml | Consolidated clippy checks into fewer steps, removed --release flag from wasm build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d5f9fd8 to
c57ff4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.