chore: use digests instead of tags for pinned images#35
Draft
mayeut wants to merge 3 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates cibuildwheel’s pinned Linux container image handling to use immutable OCI digests (e.g., @sha256:...) instead of mutable tags, improving reproducibility and supply-chain safety for manylinux/musllinux builds.
Changes:
- Switched
pinned_docker_images.cfgentries from:<tag>to@sha256:<digest>(with the originating tag noted as an inline comment). - Updated options parsing to support inline comments in the pinned-images config.
- Updated unit tests to expect digest-style image references and updated the docker image update script to emit digests.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| unit_test/main_tests/main_options_test.py | Updates assertions to match digest-based pinned image strings. |
| cibuildwheel/resources/pinned_docker_images.cfg | Replaces pinned tags with pinned digests (and adds inline tag metadata). |
| cibuildwheel/options.py | Adjusts pinned-image config parsing to allow inline comments. |
| bin/update_docker.py | Refactors image pin update logic to resolve and write digests instead of tags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.