feat: use digests instead of tags for pinned images#36
Draft
mayeut wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates cibuildwheel’s Docker image pinning approach to use immutable image digests (@sha256:...) instead of mutable tags, and adjusts the update tooling and tests to match.
Changes:
- Switch
pinned_docker_images.cfgentries from:tagpins to@sha256:digestpins (with the former tag kept as an inline comment). - Update config parsing to ignore inline
# ...comments in pinned image values. - Adjust test expectations and Docker warmup logic to work with digest-pinned images.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
unit_test/main_tests/main_options_test.py |
Updates unit test expectations from :* to @* to reflect digest-pinned images. |
test/conftest.py |
Updates Docker warmup logic to handle digest references by committing to a tag and monkeypatching env vars. |
cibuildwheel/resources/pinned_docker_images.cfg |
Replaces pinned tags with pinned digests and records tag versions as inline comments. |
cibuildwheel/options.py |
ConfigParser now supports inline # comments so pinned image values parse correctly. |
bin/update_docker.py |
Refactors pin update logic to resolve and write digests (with cached registry lookups). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
459edce to
6f0281a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.