Fix: highlight active line in language-specified codeblock #289
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file. | |
|
|
||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| See this project's [releases](https://github.com/mayurankv/Obsidian-Code-Styler/releases). | ||
| <!-- Create a new release using `npm version x.y.z`` (or increment `z` with `patch`, `y` with `minor` and `x` with `major`) --> | ||
| <!-- Rerelease a broken release with `npm run rerelease`--> | ||
| <!-- Revert a broken commit using `gitrev commitSHA` (`git reset --hard commitSHA && git push --force origin commitSHA:master`) --> | ||
|
|
@@ -20,6 +20,10 @@ See this project's [releases](/../../../releases). | |
|
|
||
| ## [Unreleased] | ||
|
Author
There was a problem hiding this comment. Removed this
Owner
There was a problem hiding this comment. Hiya sorry, this title is of equal level to the version titles below and is empty as I haven't locally developed any changes that are yet to be released. But if for example, I added a new feature X and pushed to github, I'd note it here and then when the new version of the plugin is released, this would automatically get set as the new version title. i.e. Since your changes aren't released as a new version yet, I would put them under 'Unreleased' and when a new version is pushed they would automatically be listed under the latest version. Does that make sense? (Not sure this is the best method since this is the only repo i have in any level of 'production' status but it's worked for me so far so if that's not traditionally what's done, always happy to update).
Author
There was a problem hiding this comment. Ohh gotcha that makes sense! I'd missed the section above where it's mentioned that the changelog is based on Keep a Changelog. I can think of a couple slightly less ambiguous approaches to this (and e.g. Common Changelog avoids the Unreleased section entirely for a couple reasons), but since this is already following Keep a Changelog, it's probably better to keep it as-is than to diverge from that documented format. Reverted back! |
||
|
|
||
| ### Fixed | ||
|
|
||
| - Codeblock active line highlight when language is specified | ||
|
|
||
| ## [1.1.7] - 2024-02-23 | ||
|
|
||
| ### Fixed | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're at it - this was a broken link (missing the repo part of the URL), so I went ahead and fixed it with an absolute link if that sounds good to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, I also noticed that manifest.json has a broken Buy Me A Coffee link. If you want I can also go ahead and add that quick fix to this PR (or separate PR if you'd prefer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh so sorry for the late reply, finally found some time to work on this. I'm doing a major refactor of the plugin including how the line highlighting works. I'm going to complete that fix and then come and add the issues you raise here. Sorry that its taken so long and that I won't actually be directly using your work, but the refactor is making the code (and css) soooo much clearer and easier to work with so hopefully future PRs will be easier!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey no worries at all, there's no pressure or rush! Glad to hear about the refactoring, that sounds satisfying (and useful) to accomplish :)