Fixing wrong WORKDIR syntax

[schinzelh]

According to https://docs.docker.com/engine/reference/builder/ the WORKDIR instruction uses the form

WORKDIR /path/to/workdir

so the brackets provided are causing a weird workdirectory name of

gitian@196210e79d8f:/[/gitian]$

inside the container. This fixes it..

Additionally the make depends downloads phase now relies on curl to be installed.

[guruvan]

@schinzelh Thanks Yes the brackets make a significant difference. I'm just sitting back down to look at gitian builds this week. Looks fine, but before I merge I'll want to refresh all my local work.

[schinzelh]

Good stuff - really nice piece of work, works like charm for me on Dash 12.1/Linux.

What's the rationale of having three almost identical Dockerfiles btw? Couldn't they be unified?

[guruvan]

The original intention was to fully automate gitian builds for PRs etc. With a full build matrix, building all the pieces from scratch on travis was not possible without paid account. Timeouts are too short to build everything. The multiple dockerfiles provide the necessary multiple stages, as well as the ability to build easily locally. For my own purposes, Dockerhub also builds the various images as well, to save time in testing.

Since docker doesn't really take a directive inside the dockerfile to build based on env variables (at of when this was built) it's not really possible to combine the dockerfiles that are used for different purposes.

It's been a bit since I've worked on it. Glad it works well for you. Are you using in travis?

[schinzelh]

Thanks for the info. No, not using Travis, but our own Atlassian Bamboo CI Server. Dockerizing this is actually really neat :)