Completed requirements specification (PyQt4 and requests) and improved setup.py#5
Open
davidlj95 wants to merge 1 commit intomazaclub:masterfrom
Open
Completed requirements specification (PyQt4 and requests) and improved setup.py#5davidlj95 wants to merge 1 commit intomazaclub:masterfrom
davidlj95 wants to merge 1 commit intomazaclub:masterfrom
Conversation
Added extra documentation explaining PyQt must be installed Moved some files to avoid setup fail without PyQt4 installed
Xiaoyang-Zhu
added a commit
to Xiaoyang-Zhu/hashmal
that referenced
this pull request
Sep 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist:
setup.pyto work without havingPyQt4installed (so you can install it later):hashmal_lib.entry_pointsmodule to contain entry pointshashmal_lib.gui_utilsmodule's constanthashmal_entry_pointsto previously created fileContains a reference to it to mantain constant in both modules
setup.pyimportfrom hashmal_lib.gui_utils import hashmal_entry_pointstofrom hashmal_lib.entry_points import hashmal_entry_pointshashmal_lib.__init__module imports to inside the class (so doesn't importPyQt4until instanced)requestsmodule as a requirement inrequirements.txtREADME.mdthePyQt4requirement and a basic how-to to install the modulebuild/anddist/to.gitignore