Skip to content

fix(cli): restore "Successfully exported state" confirmation on export#14

Merged
mazze93 merged 1 commit into
mainfrom
claude/fix-export-confirmation
Jun 6, 2026
Merged

fix(cli): restore "Successfully exported state" confirmation on export#14
mazze93 merged 1 commit into
mainfrom
claude/fix-export-confirmation

Conversation

@mazze93

@mazze93 mazze93 commented May 30, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the failing CI on main (and therefore every PR branched from it, including #11).

The integration test testExportAndImportAcceptUserFlagBeforeCommandFlag asserts the export command's stdout contains "Successfully exported state". During the Edgar/RavenRenderer work the CLI's export-success path (Sources/contextsynapse/main.swift) was changed to print only the themed edgar · session folded → … line, dropping the plain confirmation. The import path still prints its plain Successfully imported state from: … line — so only export lost its confirmation, an asymmetry that breaks the test whenever swift test builds and execs the CLI binary.

Change

One line: restore the plain Successfully exported state to: <file> confirmation on export success, alongside Edgar's flourish. Export and import are now symmetric, and the integration test passes.

     if core.exportState(to: url, metadata: metadata) {
+        print("Successfully exported state to: \(outputFile)")
         print("\u{001B}[2medgar · session folded → \(outputFile)\u{001B}[0m")
         exit(0)
     }

Test plan

  • Build, test, and guardrails (macos-15) green — the failing assertion at Tests/BayesianConvergenceTests.swift:223 now passes
  • Export still prints the Edgar session folded line (no UX regression)

https://claude.ai/code/session_01BBeeaADak63VbvE7kuYw96


Generated by Claude Code

The Edgar/RavenRenderer rework replaced the export command's plain
confirmation line with only the themed "session folded" message, while
the import path kept its "Successfully imported state from:" line. This
asymmetry broke testExportAndImportAcceptUserFlagBeforeCommandFlag, which
asserts the export stdout contains "Successfully exported state" — the
test fails whenever `swift test` builds and execs the CLI binary, which
is what turns CI red.

Restore the plain confirmation line on export success (keeping Edgar's
flourish) so export and import are symmetric and the integration test
passes.

https://claude.ai/code/session_01BBeeaADak63VbvE7kuYw96
@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Sources/contextsynapse/main.swift is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6b9b3f6c-d880-4c34-8559-5ec3f458f905

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-export-confirmation

Comment @coderabbitai help to get the list of available commands and usage tips.

@mazze93 mazze93 merged commit 1159b05 into main Jun 6, 2026
4 checks passed
@mazze93 mazze93 deleted the claude/fix-export-confirmation branch June 6, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants