[Fixtures] add GLP Matrix Eye Series#1944
Open
ClarkLiam wants to merge 10 commits intomcallegari:masterfrom
Open
[Fixtures] add GLP Matrix Eye Series#1944ClarkLiam wants to merge 10 commits intomcallegari:masterfrom
ClarkLiam wants to merge 10 commits intomcallegari:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds fixture definitions for two GLP Matrix Eye series fixtures to the QLC+ fixture library. Both fixtures are LED-based color changers with multiple heads that support RGB and RGBAL color mixing.
Changes:
- Added fixture definition for GLP Matrix Eye 2 with 6 DMX modes supporting 2 heads
- Added fixture definition for GLP Matrix Eye 4 with 6 DMX modes supporting 4 heads
- Updated FixturesMap.xml to register both new fixtures
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| resources/fixtures/GLP/GLP-Matrix-Eye-4.qxf | New fixture definition for Matrix Eye 4 (4-head LED color changer) with multiple DMX modes |
| resources/fixtures/GLP/GLP-Matrix-Eye-2.qxf | New fixture definition for Matrix Eye 2 (2-head LED color changer) with multiple DMX modes |
| resources/fixtures/FixturesMap.xml | Added entries for both new GLP Matrix Eye fixtures in alphabetical order |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixture Information
Manufacturer:
GLP
Model:
Matrix Eye 2,
Matrix Eye 4
Mode(s) included:
Matrix Eye 2:
Matrix Eye 4:
Channels used:
Matrix Eye 2: 53ch
Matrix Eye 4: 83ch
Testing
Source(s) of Information
Matrix Eye 2 - Manufacturers Site
Matrix Eye 4 - Manufacturers Site