Avoid hidden lifetime parameters for latest Rust nightly#103
Open
weikengchen wants to merge 4 commits intomcarton:masterfrom
Open
Avoid hidden lifetime parameters for latest Rust nightly#103weikengchen wants to merge 4 commits intomcarton:masterfrom
weikengchen wants to merge 4 commits intomcarton:masterfrom
Conversation
In the current nightly, Debug trait's implementation now may need to add <'_>, as hidden lifetime parameters would now become a warning.
And it could be difficult for developers to find out why, as the code of Derivative is not exposed in the compiler's warnings.
```
warning: hidden lifetime parameters in types are deprecated
--> ff/src/fields/macros.rs:96:9
|
96 | / /// Represents an element of the prime field F_p, where `p == P::MODULUS`.
97 | | /// This type can represent elements in any field of size at most
98 | | #[doc = $field_size]
99 | | /// bits.
... |
114 | | pub PhantomData<P>,
115 | | );
| |__________^ expected named lifetime parameter
```
Author
|
I will research a little bit to see how to fix the issue here. What happens is the following: |
Author
|
Ready for CI. Added the following version limits to the dev_dependency to avoid an error in the CI test suite. Local github actions execution is passing. Note: It is very unlikely to pass the clippy check unless we change msrv. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the recent nightly, Debug trait's implementation now may need to add <'_>, as hidden lifetime parameters would now become a warning.
And it could be difficult for developers to find out why, as the code of Derivative is not exposed in the compiler's warnings.