fix: resolve review issues before v1.0.0 release

packages/discover/src/discover.ts

@@ -86,16 +86,14 @@ export class Discover {
    * @returns An unsubscribe function to deregister the service
    */
   register<M = Record<string, any>>(type: string, meta?: M): () => void {
-    const _meta = meta ?? {}
-
     const n = this.#nextInstanceIds.get(type) ?? 1
     this.#nextInstanceIds.set(type, n + 1)
 
     const hostname = n === 1
       ? `${type}.discover`
       : `${type.replace(/^([^.]+)/, `$1-${n}`)}.discover`
 
-    const body = JSON.stringify({ meta: _meta })
+    const body = meta !== undefined ? JSON.stringify({ meta }) : '{}'
 
     const post = (): void => {
       const nonce = unique()
@@ -110,7 +108,7 @@ export class Discover {
 
     const timer = system.runInterval(post, ms2ticks(this.#options.heartbeatInterval))
 
-    const registration: LocalRegistration = { fullname: hostname, meta: _meta, timer }
+    const registration: LocalRegistration = { fullname: hostname, meta, timer }
     this.#localServices.set(hostname, registration)
 
     return () => {

packages/ipc/src/chunk.ts

@@ -83,6 +83,10 @@ export class Chunker {
       }
       this.#buffer.set(id, pending)
     }
+    else if (pending.compressed !== compressed) {
+      this.#buffer.delete(id)
+      return { done: false }
+    }
 
     if (pending.fragments[seq] !== undefined) {
       return { done: false }

packages/ipc/src/ipc.ts

@@ -272,7 +272,7 @@ export class IPC {
 
     const seq = url.searchParams.get('seq')
     const total = url.searchParams.get('total')
-    const compressed = url.searchParams.get('c') !== null
+    const compressed = url.searchParams.get('c') === '1'
 
     if (seq !== null && total !== null) {
       this.#handleChunk(id, channel, Number(seq), Number(total), payload, compressed)

packages/protocol/src/protocol.ts

@@ -103,9 +103,14 @@ export class Protocol {
     }
   }
 
-  once(handler: (event: BedrockReceiveEvent) => void): () => void {
+  once(handler: (event: BedrockReceiveEvent) => void): () => void
+  once(handler: (event: BedrockReceiveEvent) => void, options: { sourceType?: ScriptEventSource }): () => void
+  once(handler: (event: BedrockReceiveEvent) => void, options?: { sourceType?: ScriptEventSource }): () => void {
     let off: () => void
     const wrapped = (event: BedrockReceiveEvent): void => {
+      if (options?.sourceType && event.sourceType !== options.sourceType) {
+        return
+      }
       off()
       handler(event)
     }

packages/rpc/src/rpc.ts

@@ -146,11 +146,19 @@ export class RPC {
 
     try {
       const parsed = JSON.parse(body)
-      if (parsed && typeof parsed === 'object' && 'error' in parsed) {
-        pending.reject(new Error(parsed.error as string))
+      if (parsed && typeof parsed === 'object') {
+        if ('error' in parsed) {
+          pending.reject(new Error(parsed.error as string))
+        }
+        else if ('data' in parsed) {
+          pending.resolve(parsed.data)
+        }
+        else {
+          pending.reject(new Error('RPC: invalid response format — expected {data} or {error}'))
+        }
       }
       else {
-        pending.resolve(parsed && 'data' in parsed ? parsed.data : undefined)
+        pending.reject(new Error('RPC: invalid response body'))
       }
     }
     catch {

packages/runtime/README.md

@@ -24,7 +24,7 @@ npm install @mcbe-mods/runtime
 | `@mcbe-mods/log` | `Log` | `LogLevel`, `LogOptions` |
 | `@mcbe-mods/protocol` | `Protocol` | `BedrockReceiveEvent`, `ProtocolCipher`, `ProtocolOptions` |
 | `@mcbe-mods/rpc` | `RPC` | `RPCOptions` |
-| `@mcbe-mods/utils` | `Base64`, `color`, `unique`, `ms2ticks`, … | (all types included) |
+| `@mcbe-mods/utils` | `Base64`, `Color`, `unique`, `ms2ticks`, … | (all types included) |
 
 ```ts
 import { Base64, Cipher, Discover, IPC, Log, Protocol, RPC } from '@mcbe-mods/runtime'

packages/utils/src/Experience.ts → packages/utils/src/experience.ts

@@ -105,6 +105,7 @@ export class Experience {
    * @returns {this} self
    */
   setLevel(level: number): this {
+    this.#xp = 0
     this.#level = 0
     this.addLevel(level)
     return this

packages/utils/src/index.ts

@@ -1,12 +1,12 @@
 export { Base64 } from './base64'
 export { Color } from './color'
 export type { StyleId, Stylizer } from './color'
-export { Experience } from './Experience'
-export { getCubeRange, getSphereRange } from './getCubeRange'
-export type { Location } from './getCubeRange'
+export { Experience } from './experience'
 export { getRandomProbability } from './getRandomProbability'
 export { getRandomRangeValue } from './getRandomRangeValue'
 export { ms2ticks } from './ms2ticks'
+export { getCubeRange, getSphereRange } from './range'
+export type { Location } from './range'
 export { splitGroups } from './splitGroups'
 export { utf8Decode, utf8Encode } from './textCodec'
 export { unique } from './unique'

packages/utils/src/getCubeRange.ts → packages/utils/src/range.ts

@@ -4,12 +4,6 @@ export interface Location {
   z: number
 }
 
-/**
- * With {@link location} as the center, get all coordinates within a cube of side length `(2*radius+1)`.
- * @param location - Center position
- * @param radius - Half side length (default 1)
- * @returns Array of positions within the cube
- */
 export function getCubeRange(location: Location, radius: number = 1): Location[] {
   const centerX = location.x
   const centerY = location.y
@@ -27,12 +21,6 @@ export function getCubeRange(location: Location, radius: number = 1): Location[]
   return positions
 }
 
-/**
- * With {@link location} as the center, get all coordinates within a sphere of radius {@link radius}.
- * @param location - Center position
- * @param radius - Sphere radius (default 1)
- * @returns Array of positions within the sphere
- */
 export function getSphereRange(location: Location, radius: number = 1): Location[] {
   const centerX = location.x
   const centerY = location.y