Remove Playwright browser caching from CI workflows#149
Merged
Conversation
Remove cache-based conditional logic for Playwright browser installation. The cache path (~/.cache/ms-playwright) didn't match where Playwright was looking for browsers (node_modules/playwright-core/.local-browsers/), causing build failures when cache was hit but browsers weren't found. Always running 'npx playwright install chromium --with-deps' ensures the correct browser version is installed for the current Playwright version in both test and build jobs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the CI workflow by removing the Playwright browser caching logic and conditional installation steps. The workflows now always perform a fresh installation of Playwright browsers with dependencies.
Changes
actions/cache@v4step that cached Playwright browsers at~/.cache/ms-playwrightsteps.playwright-cache.outputs.cache-hit)npx playwright install chromium --with-depsnpx playwright install-deps chromiumstep that only ran on cache hitsRationale
This change trades caching complexity for simplicity and reliability. While caching can improve CI performance, it introduces conditional logic that can be error-prone. Always performing a fresh installation ensures consistent behavior across runs and eliminates potential issues with stale cached browsers or missing system dependencies.