fix(ios): drop legacy new-arch podspec block that breaks RN 0.84+#14
Open
lorenc-tomasz wants to merge 1 commit intomccsoft:masterfrom
Open
fix(ios): drop legacy new-arch podspec block that breaks RN 0.84+#14lorenc-tomasz wants to merge 1 commit intomccsoft:masterfrom
lorenc-tomasz wants to merge 1 commit intomccsoft:masterfrom
Conversation
Keep the library on bridge interop and avoids RN 0.84 iOS build failures related to Folly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13
Summary
Removes the conditional New Architecture (Fabric/TurboModules) pod dependencies and compiler flags from the podspec to fix compatibility with React Native 0.84+.
The library continues to work on New Architecture via RN's built-in interop layer, which wraps legacy RCTBridgeModule implementations automatically - no TurboModule/Codegen implementation is required on the library side.
Patch-Package workaround
Until this fix is published as a new release, users on RN 0.84+ can apply a patch-package patch as an immediate workaround.
@mccsoft+react-native-matomo+1.0.8.patch