Draft
Conversation
Collaborator
Author
|
@munkm @ilhamv should I add support for energy weight windows in this PR as well or do a follow up PR for that? Also, the added documentation to the website in this PR is pretty sad, but I was unsure as to whether I should expand the docs around all of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds mesh-based weight windows to MCDC. In the current state, only spatial weight windows are supported. Additionally, the particle "passes through" a weight window on collision, as opposed to whenever a particles crosses into a new mesh bin.
Weight windows are stored as three separate 1D arrays of floats:
lower_weights,target_weights,upper_weights.To test the additions, I added a few unit tests to
unit/transport/technique/weight_windows.py.Types of changes
Developer Checklist
Associated Issues and PRs
Associated Developers