Adds multi-select support#1360
Open
jtreminio wants to merge 10 commits intomcmonkeyprojects:masterfrom
Open
Conversation
mcmonkey4eva
reviewed
May 2, 2026
mcmonkey4eva
reviewed
May 2, 2026
mcmonkey4eva
reviewed
May 2, 2026
mcmonkey4eva
reviewed
May 2, 2026
mcmonkey4eva
reviewed
May 2, 2026
mcmonkey4eva
reviewed
May 2, 2026
mcmonkey4eva
reviewed
May 2, 2026
mcmonkey4eva
reviewed
May 2, 2026
mcmonkey4eva
reviewed
May 2, 2026
mcmonkey4eva
reviewed
May 2, 2026
mcmonkey4eva
reviewed
May 2, 2026
jtreminio
commented
May 2, 2026
Comment on lines
+68
to
+76
| let getMeta = (metadata) => metadata ? (JSON.parse(metadata) || {}) : {}; | ||
| let metaParsed = getMeta(metadata); | ||
| let isStarred = (e) => { | ||
| let currentMeta = e && e.dataset ? getMeta(e.dataset.metadata) : {}; | ||
| if (Object.keys(currentMeta).length == 0) { | ||
| currentMeta = metaParsed; | ||
| } | ||
| return currentMeta.is_starred; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
There was a bug in your original implementation:
- metadata would initially not exist on an item, causing exception on
let metaParsed = JSON.parse(metadata); - metadata would be stale on reads below. Clicking "Enable Starred" would add the needed metadata and also star the items, but then clicking "Disable(d) Starred" would still see stale metadata and not unstar items
- Fixed speling
mcmonkey4eva
reviewed
May 2, 2026
| let textBlock = createDiv(null, 'model-descblock'); | ||
| textBlock.tabIndex = 0; | ||
| textBlock.innerHTML = desc.description; | ||
| textBlock.addEventListener('click', (e) => { |
Member
There was a problem hiding this comment.
What's with all these new click listeners?
Contributor
Author
There was a problem hiding this comment.
This one is necessary. I couldn't need get multi-select click to select a card if I clicked the description otherwise.
mcmonkey4eva
reviewed
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CleanShot.2026-04-29.at.23.31.21.mp4