Skip to content

Allow saving generated ControlNet previews#1364

Open
jtreminio wants to merge 1 commit intomcmonkeyprojects:masterfrom
jtreminio:controlnet-save
Open

Allow saving generated ControlNet previews#1364
jtreminio wants to merge 1 commit intomcmonkeyprojects:masterfrom
jtreminio:controlnet-save

Conversation

@jtreminio
Copy link
Copy Markdown
Contributor

CleanShot.2026-05-02.at.13.05.55.mp4

@jtreminio jtreminio marked this pull request as ready for review May 2, 2026 18:07
}
if (user_input.Get(T2IParamTypes.ControlNetPreviewOnly, false))
{
string controlNetInputFolder = $"inputs/_comfy{backend.Data.ID}/";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wh... what's going on here? This seems very out of place

return `inputs/_comfy${parsedId}`;
}
}
return 'inputs';
Copy link
Copy Markdown
Member

@mcmonkey4eva mcmonkey4eva May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this function except this one line is silly. Probably something like inputs/controlnet/ is the folder to use - edit oh that's literally what you're doing anyway, you just split it across places lol

}
genericRequest('AddImageToHistory', data, res => {
if (inputBrowserHelper.inputImageBrowser) {
inputBrowserHelper.inputImageBrowser.lightRefresh();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is redundant, I'm guessing you copied from the code in the input browser itself, but that's a special case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants