New launcher version with proper executable for shortcuts#55
Open
gabrielmagno wants to merge 1 commit intomcobit:masterfrom
Open
New launcher version with proper executable for shortcuts#55gabrielmagno wants to merge 1 commit intomcobit:masterfrom
gabrielmagno wants to merge 1 commit intomcobit:masterfrom
Conversation
|
Nice one. |
|
I installed the newest version and i seem to be having this same issue. Am I just installing the wrong thing? Im new to this so sorry if im just mixed up somehow. |
|
These changes haven't been accepted yet so the current version is still the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried adding a shortcut for the Retrosmc launcher in my skin (pellucid), but retropie was being started during the dialog for creating the shortcut, before it was properly created.
I investigated a little bit, then realized that the proper plugin type (extension point) for retrosmc launcher should be changed. I modified it from
xbmc.python.pluginsourcetoxbmc.python.script, and now it is properly working.I think this would apply for many other plugins, menus and shortcuts. This would probably close #37 and #54 .