test(e2e): stop the wine teardown from failing a passing test - #404
Merged
Conversation
`cross-build-test` went red on main at 0006ce6 (run 31336526583) with a log that ends: OK rm: cannot remove '/tmp/tmp.XgyezkVtrY/wineprefix': Directory not empty The test passed. `wine` leaves a wineserver running after the process it launched exits, and that server keeps writing into $WINEPREFIX, so the EXIT trap's `rm -rf` races it. Under `set -e` the failing trap becomes the script's exit status, so a green test reports as a red job — and the verdict it reports is about a temp directory, not about mcpp. Shut the server down and wait for it before deleting, and let cleanup keep the status the test already earned. Cleanup runs after the verdict is printed; it has no business changing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cross-build-test在 main 的0006ce6上是红的（run 31336526583），日志结尾是：测试是过的。
wine在它启动的进程退出之后仍然留着一个 wineserver，而那个 server 会继续往$WINEPREFIX里写，于是 EXIT trap 里的rm -rf和它抢。在set -e下，trap 的非零状态变成脚本的退出码 —— 一个绿的测试因此报成红的 job，而它报的还是一个临时目录的事，不是 mcpp 的事。改法：删之前先关掉 wineserver 并等它退出；同时让清理保留测试已经挣到的状态。清理跑在结论打印之后，它没有资格改结论。
全仓只有这一个测试用
WINEPREFIX。