clustermd_tests: control speed limits on both nodes#271
Open
Damenly wants to merge 1 commit into
Open
Conversation
Before this commit, record_system_speed_limit() in clustermd_tests/func.sh is never called, but restore_system_speed_limit() is always called. Which means the original system speed limits cannot be restored. The second issue is that clustermd_tests/func.sh:control_system_speed_limit() only sets local machine's speed_limit_min and speed_limit_max but remote node won't be influenced. This causes some cases like 03r1_switch-recovery to fail because the expected operation may have been done before check. Here introduce array nodes_test_speed_limit_min and nodes_test_speed_limit_max to set raid sync speed limits for NODE1 and NODE2. nodes_system_speed_limit_min and nodes_system_speed_limit_max are for recording origin values. NOTE: test_speed_limit_min and test_speed_limit_max are not used by clustermd_tests anymore. Many clustermd tests require slow speed on NODE1 but faster speed on NODE2 so nodes_test_speed_limit_min and nodes_test_speed_limit_max are necessary. Signed-off-by: Su Yue <glass.su@suse.com>
Damenly
force-pushed
the
control-clustermd-speed-limit
branch
from
a3425f2 to
e8f9286
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, record_system_speed_limit() in clustermd_tests/func.sh is never called, but restore_system_speed_limit() is always called. Which means the original system speed limits cannot be restored.
The second issue is that clustermd_tests/func.sh:control_system_speed_limit() only sets local machine's speed_limit_min and speed_limit_max but remote node won't be influenced. This causes some cases like 03r1_switch-recovery to fail because the expected operation may have been done before check.
Here introduce array nodes_test_speed_limit_min and nodes_test_speed_limit_max to set raid sync speed limits for NODE1 and NODE2. nodes_system_speed_limit_min and nodes_system_speed_limit_max are for recording origin values.
NOTE: test_speed_limit_min and test_speed_limit_max are not used by clustermd_tests anymore. Many clustermd tests require slow speed on NODE1 but faster speed on NODE2 so nodes_test_speed_limit_min and nodes_test_speed_limit_max are necessary.
Assisted-by: Codex:gpt-5.5
Signed-off-by: Su Yue glass.su@suse.com