Separate top level explicit exposes by lines [CLI v4.2.2] [Elm v0.5.4]#92
Open
JQuezada0 wants to merge 2 commits intomdgriffith:mainfrom
Open
Separate top level explicit exposes by lines [CLI v4.2.2] [Elm v0.5.4]#92JQuezada0 wants to merge 2 commits intomdgriffith:mainfrom
JQuezada0 wants to merge 2 commits intomdgriffith:mainfrom
Conversation
miniBill
suggested changes
May 26, 2024
| "name": "mdgriffith/elm-codegen", | ||
| "summary": "A code generation library for Elm", | ||
| "license": "BSD-3-Clause", | ||
| "version": "4.2.1", |
Contributor
There was a problem hiding this comment.
In general, you should never bump the package version in a PR, unless you're the author
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "elm-codegen", | |||
| "version": "0.5.3", | |||
Comment on lines
+361
to
+369
| renderedWithSeparator = | ||
| case List.reverse renderedTopLevelExposes of | ||
| head :: tail -> | ||
| head | ||
| :: List.map (Pretty.a <| Pretty.char ',') tail | ||
| |> List.reverse | ||
|
|
||
| _ -> | ||
| renderedTopLevelExposes |
Contributor
There was a problem hiding this comment.
Is this needed or would softlines just work on the result of Pretty.join?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the number of input types grows to a point where concatenating them with a comma and a space causes the line to exceed
65535characters, elm will fail to parse the file.This change uses
softlinesfrom theelm-pretty-printerpackage to break up the exposes list as needed, but it prefers one line if possible.