Skip to content

import(…, { with: { type: "json" } }) is standard track #25995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caugner merged 4 commits into from
Feb 24, 2025
Merged

import(…, { with: { type: "json" } }) is standard track #25995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cc0624
`import(…, { with: "json" })` is standard track
ddbeck Feb 21, 2025
e0470c7
Also set `trailing_commas_in_dynamic_import` to standard track
ddbeck Feb 21, 2025
8ba99d2
Add spec URL to trailing commas feature
ddbeck Feb 22, 2025
52ed946
Add spec URL to options parameter feature
ddbeck Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion javascript/grammar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,7 @@
"trailing_commas_in_dynamic_import": {
"__compat": {
"description": "Trailing comma in dynamic import",
"spec_url": "https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-import-call-runtime-semantics-evaluation",
"support": {
"chrome": {
"version_added": "91"
Expand Down Expand Up @@ -954,7 +955,7 @@
},
"status": {
"experimental": false,
"standard_track": false,
"standard_track": true,

@ddbeck ddbeck Feb 21, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set this as well, since it appears to be reflecting the same underlying fact.

@caugner caugner Feb 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-import-call-runtime-semantics-evaluation as a spec_url then?

@ddbeck ddbeck Feb 22, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with 8ba99d2.

@ddbeck ddbeck Feb 22, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's no reason not to do it for both features. I've added it with 52ed946.

"deprecated": false
}
}
Expand Down
3 changes: 2 additions & 1 deletion javascript/operators/import.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@
"options_parameter": {
"__compat": {
"description": "The `options` parameter",
"spec_url": "https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-import-calls",
"support": {
"chrome": {
"version_added": "91"
Expand Down Expand Up @@ -154,7 +155,7 @@
},
"status": {
"experimental": false,
"standard_track": false,
"standard_track": true,
"deprecated": false
}
}
Expand Down