Update Firefox support for WebAssembly JS-PI#29783
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
|
Thanks — preview URLs look good; no rendering issues spotted on my side. |
Elchi3
left a comment
There was a problem hiding this comment.
Thanks for your PR! This appears to be shipping in Firefox 153, according to https://bugzilla.mozilla.org/show_bug.cgi?id=2044809
chrisdavidmills
left a comment
There was a problem hiding this comment.
@KirtiRamchandani thanks for attempting this.
To be honest, I'd prefer you to add data for the two JSAPI features that comprise this feature, rather than a single feature data point.
The two features are:
- WebAssembly.promising() — this is a static function available on the WebAssembly object; you'd add that here: https://github.com/mdn/browser-compat-data/blob/main/webassembly/api.json
- WebAssembly.Suspending — this is an interface available on the main WebAssembly object. It only has a single sub-feature — its constructor. You'd add that as a new file, similar to https://github.com/mdn/browser-compat-data/blob/main/webassembly/api/Global.json.
They'll have the same support versions as the file you just updated, but I'd like you to delete that file and make the two updates described above instead.
See also @Elchi3's comment about the Fx support version.
See also here for the spec: https://webassembly.github.io/js-promise-integration/js-api/#jspi
|
Thanks @chrisdavidmills working on this now |
Add webassembly.api.promising_static and webassembly.api.Suspending instead of updating webassembly.jspi.
978cc8d to
35818dd
Compare
chrisdavidmills
left a comment
There was a problem hiding this comment.
@KirtiRamchandani, this is what I was hoping for, thanks!
Although, afaics, JS-PI is set to be enabled by default in Fx 153, not behind a flag. Did you have evidence to the contrary?
|
Sorry I just missed the https://hg-edge.mozilla.org/mozilla-central/rev/da1c4762d8af |
JS-PI is enabled by default in Firefox 153 per bug 2044809.
|
The lint check found auto-fixable issues. Apply suggested changes (attributed to |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Elchi3
left a comment
There was a problem hiding this comment.
Thanks for your PR!
https://github.com/mdn/browser-compat-data/blob/main/webassembly/jspi.json also needs to be updated to say it is supported in Firefox 153
Elchi3
left a comment
There was a problem hiding this comment.
Actually, I got that webassembly.jspi key covered in #29883.
The additional keys that Chris rightly pointed out aren't in webref (and therefore not in the collector) as they are only specified in a forked version of the Wasm spec, so yes let's get them in manually here. Thank you!
Problem
mdn/content#44167 tracks Firefox 152 Nightly support for WebAssembly JavaScript Promise Integration (JS-PI), but BCD still marked Firefox as unsupported.
Root cause
webassembly/jspi.jsonhad no Firefox support entry for the new Nightly implementation.Solution
Mark Firefox 152 support behind the
javascript.options.wasm_js_promise_integrationpreference. Firefox for Android continues to mirror desktop Firefox for this feature.Tests run
node lint/lint.js webassembly/jspi.jsonnode_modules/.bin/prettier.cmd --check webassembly/jspi.jsonnode -e "JSON.parse(require('fs').readFileSync('webassembly/jspi.json','utf8')); console.log('ok')"git diff --check