fix: Add details for createDTMFSender() method in RTCPeerConnection interface#33955
Merged
Josh-Cena merged 10 commits intoSep 23, 2024
Merged
Conversation
github-actions
Bot
added
Content:WebAPI
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Preview URLs (comment last updated: 2024-09-18 14:03:06) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>
Elchi3
requested review from
a team and
wbamberg
and removed request for
a team and
Elchi3
wbamberg
previously requested changes
Jul 24, 2024
Member
|
@bc-lee, do you have time to come back to this? |
Contributor
Author
|
Yes, but not today or tomorrow (at the moment, I'm busy with other things). I'll come back to this in a few days. |
Josh-Cena
added
the
awaiting response
Co-authored-by: wbamberg <will@bootbonnet.ca>
Josh-Cena
removed
the
awaiting response
Collaborator
|
It's definitely non standard - updated in BCD here mdn/browser-compat-data#24442 These fixes are good, but I worry that they will cause problems with the auto-update tooling when the BCD changes goes in. So might be worth waiting until BCD has updated, and the scripts for fixing up status have run. |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Member
|
Will get this merged before next week |
fiji-flo
pushed a commit
that referenced
this pull request
Oct 2, 2024
…nterface (#33955) * fix: Add details for createDTMFSender() method in RTCPeerConnection interface Fixes #33954 * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/api/rtcpeerconnection/createdtmfsender/index.md Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: wbamberg <will@bootbonnet.ca> * Update index.md * Not non-standard * Update index.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com> Co-authored-by: wbamberg <will@bootbonnet.ca> Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33954