Add Baseline banner to Fullscreen API page#43478
Merged
hamishwillee merged 1 commit intomdn:mainfrom Mar 26, 2026
Merged
Conversation
Contributor
|
Preview URLs (1 page) External URLs (1)URL: (comment last updated: 2026-03-23 00:13:12) |
89260c4 to
e05f150
Compare
caugner
reviewed
Mar 20, 2026
e05f150 to
9ca2da3
Compare
This page was referencing the `browser-compat` data for the deprecated `api.Document.fullscreen` feature, which doesn't have a corresponding feature ID in `web-features`. As a result, it doesn't display a Baseline banner. By removing that key from `browser-compat`, the page will show the correct Baseline status banner.
9ca2da3 to
5d4475b
Compare
Member
In this instance, I think this is the correct thing to do. |
hamishwillee
approved these changes
Mar 26, 2026
Collaborator
hamishwillee
left a comment
There was a problem hiding this comment.
Thanks @dfabulich for the improvement and your patience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This page was referencing the
browser-compatdata for the deprecatedapi.Document.fullscreenfeature, which doesn't have a corresponding feature ID inweb-features. As a result, it doesn't display a Baseline banner.By removing that key from
browser-compat, the page will show the correct Baseline status banner.