Skip to content

Add Baseline banner to Fullscreen API page#43478

Merged
hamishwillee merged 1 commit intomdn:mainfrom
dfabulich:fullscreen-baseline
Mar 26, 2026
Merged

Add Baseline banner to Fullscreen API page#43478
hamishwillee merged 1 commit intomdn:mainfrom
dfabulich:fullscreen-baseline

Conversation

@dfabulich
Copy link
Copy Markdown
Contributor

@dfabulich dfabulich commented Mar 17, 2026

This page was referencing the browser-compat data for the deprecated api.Document.fullscreen feature, which doesn't have a corresponding feature ID in web-features. As a result, it doesn't display a Baseline banner.

By removing that key from browser-compat, the page will show the correct Baseline status banner.

@dfabulich dfabulich requested a review from a team as a code owner March 17, 2026 15:50
@dfabulich dfabulich requested review from hamishwillee and removed request for a team March 17, 2026 15:50
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Mar 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

Preview URLs (1 page)

External URLs (1)

URL: /en-US/docs/Web/API/Fullscreen_API
Title: Fullscreen API

(comment last updated: 2026-03-23 00:13:12)

Comment thread files/en-us/web/api/fullscreen_api/guide/index.md Outdated
@dfabulich dfabulich force-pushed the fullscreen-baseline branch from 89260c4 to e05f150 Compare March 20, 2026 04:18
Comment thread files/en-us/web/api/fullscreen_api/index.md
Comment thread files/en-us/web/api/fullscreen_api/guide/index.md Outdated
Comment thread files/en-us/web/api/fullscreen_api/index.md
@dfabulich dfabulich force-pushed the fullscreen-baseline branch from e05f150 to 9ca2da3 Compare March 23, 2026 00:10
@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Mar 23, 2026
@dfabulich dfabulich changed the title Add Baseline banner to Fullscreen API pages Add Baseline banner to Fullscreen API page Mar 23, 2026
This page was referencing the `browser-compat` data for the deprecated `api.Document.fullscreen` feature, which doesn't have a corresponding feature ID in `web-features`. As a result, it doesn't display a Baseline banner.

By removing that key from `browser-compat`, the page will show the correct Baseline status banner.
@dfabulich dfabulich force-pushed the fullscreen-baseline branch from 9ca2da3 to 5d4475b Compare March 23, 2026 00:11
@LeoMcA
Copy link
Copy Markdown
Member

LeoMcA commented Mar 26, 2026

I don't have concerns about removing the deprecated feature from browser-compat here, but it would be good to have a second opinion from @LeoMcA.

In this instance, I think this is the correct thing to do.

Copy link
Copy Markdown
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dfabulich for the improvement and your patience.

@hamishwillee hamishwillee merged commit 2c6874c into mdn:main Mar 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants