fix(ci): pin npx fred-ssr and rari to their @mdn packages#44600
Open
caugner wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.github/workflows/pr-test.yml:npx fred-ssr→npx --package=@mdn/fred fred-ssr.github/workflows/pr-test.yml:npx rari …→npx @mdn/rari …Motivation
Prevent dependency-confusion fallbacks in
npx fred-ssrandnpx rari.Additional details
npx <bin>resolves to the local bin only when present; otherwise npm silently downloads and runs a registry package literally named<bin>. In CI,npxassumes--yes, so this happens with no prompt.fred-ssris a bin of@mdn/fredand its bare name is unpublished (squattable); the unscopedrariname is owned by an unrelated third party, not MDN. Pinning--package=@mdn/fred/@mdn/rariguarantees the intended bins.Related issues and pull requests
Part of mdn/fred#1680.