fix(tools): treat _/- as non-delimiters in slug prefix check#620
Draft
fix(tools): treat _/- as non-delimiters in slug prefix check#620
_/- as non-delimiters in slug prefix check#620Conversation
find_non_prefix_match fell through to `_ => true` for '_' and '-', treating them as word boundaries. This caused slugs like "Mobile" to match as a complete hit inside "Mobile_accessibility", producing wrong byte offsets and making apply_suggestions skip the second fix on the same line as overlapping.
Contributor
|
a70d635 was deployed to: https://rari-pr620.review.mdn.allizom.net/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the fix-flaws search algorithm, treating
_and-as non-delimiters in the slug prefix check.find_non_prefix_matchnow treats_and-as non-delimiters,Motivation
Ensures shorter slugs don't match as a complete hit inside a longer one (e.g.
MobileinsideMobile_accessibility), which prevented fixable flaws from being fixed.Additional details
find_non_prefix_match()fell through to_ => truefor '_' and '-', treating them as word boundaries. This caused slugs like "Mobile" to match as a complete hit inside "Mobile_accessibility", producing wrong byte offsets and making apply_suggestions skip the second fix on the same line as overlapping.Related issues and pull requests
Part of mdn/fred#1462.