Skip to content

feat: allow JSON.stringify on secure config #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdrobny merged 1 commit into from
Dec 27, 2025
Merged

feat: allow JSON.stringify on secure config #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/makeSecureDeepProxy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,4 +139,15 @@ describe('makeSecureDeepProxy', () => {
proxy.a[1].b;
}, /Property b is not defined in the config/);
});

it('allows JSON.stringify on secure config', () => {
const config = {
a: 1,
nested: { b: 'text' },
};

const proxy = makeSecureDeepProxy(config);

assert.equal(JSON.stringify(proxy), '{"a":1,"nested":{"b":"text"}}');
});
});
6 changes: 4 additions & 2 deletions src/makeSecureDeepProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ function makeSecureProxy<T extends DefaultConfig>(targetObject: T): T {
// Handle Symbol and Array properties
if (
typeof prop === 'symbol' ||
// Don't throw error when using array methods
(Array.isArray(target) && Number.isNaN(Number(prop)))
/** Don't throw error when using array methods */
(Array.isArray(target) && Number.isNaN(Number(prop))) ||
/** Allow stringifying proxied config (because JSON.stringify calls this method) */
prop === 'toJSON'
) {
return Reflect.get(target, prop);
}
Expand Down