Skip to content

In Julia 1.13 fieldoffset accepts the field name #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhz2 merged 1 commit into from
Feb 2, 2026
Merged

In Julia 1.13 fieldoffset accepts the field name #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions src/MutatePlainDataArray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,26 @@ function field_offset_type_impl(::Type{T}, ::Val{S}) where {T,S}
if !isstructtype(T)
error("$T is not struct type.")
end
if S isa Symbol
fs = fieldnames(T)
findex = findfirst(==(S), fs)
if isnothing(findex)
if VERSION ≥ v"1.12"
throw(FieldError(T, S))
else
error("Cannot find field $S in type $T.")
@static if VERSION ≥ v"1.13"
fieldoffset(T, S), fieldtype(T, S)
else
if S isa Symbol
fs = fieldnames(T)
findex = findfirst(==(S), fs)
if isnothing(findex)
if VERSION ≥ v"1.12"
throw(FieldError(T, S))
else
error("Cannot find field $S in type $T.")
end
end
elseif S isa Integer
findex = S
else
error("$S is not a symbol or an integer.")
end
elseif S isa Integer
findex = S
else
error("$S is not a symbol or an integer.")
fieldoffset(T, findex), fieldtype(T, findex)
end

fieldoffset(T, findex), fieldtype(T, findex)
end

"""
Expand Down
Loading