BREAKING: Fix memory safety bug by only supporting strided arrays of isbits#8
Merged
BREAKING: Fix memory safety bug by only supporting strided arrays of isbits#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
This is a breaking change.
The array element type now must be
isbitstype:Before, the chain of structs just had to be immutable. However, as seen in #7, the exact memory layout of non
isbitstypestructs is currently not well documented.Switch from
pointerto the strided array interface:The
pointerfunction is not recommended, and has subtle gotchas, especially if Julia is run with a moving GC.The strided array interface is being used as documented in JuliaLang/julia#59466
The
aref(a)[1]._3syntax for accessing a field index is replaced witharef(a)[1].:3orgetproperty(aref(a)[1], 3).This simplifies the code and avoids ambiguities when a field might be named
_3.