Fixes #81 - Look-ups always have "Sorry no definition found"#85
Open
Omkar-Shetkar wants to merge 2 commits intomeetDeveloper:masterfrom
Open
Fixes #81 - Look-ups always have "Sorry no definition found"#85Omkar-Shetkar wants to merge 2 commits intomeetDeveloper:masterfrom
Omkar-Shetkar wants to merge 2 commits intomeetDeveloper:masterfrom
Conversation
|
Thx for this PR! I'm just a user of the addon. Do you know if it is possible to install the addon from a local git repo (including your fix)? |
Author
Use about:debugging → Load Temporary Add-on and point to load |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing Google with https://dictionaryapi.dev/.
Root cause:
This extension works based on DOM parsing of Google search HTML response of "define $word".
Recently, Google search result page has undergone major change due to AI integration.
This has broken this add-on.
Due to AI integration, other search result page parsing seems volatile.
Better alternative to use dictionaryapi.dev, which is free and from @meetDeveloper. :)
Fixes #81
Reviewer @meetDeveloper