Add support for TextRoom plugin (Janus API only)#61
Merged
Conversation
atoppi
reviewed
Jun 12, 2025
Member
Author
|
Thanks, comments should have been all addressed 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds partial support for the TextRoom plugin. I say "partial" because it only covers what you can do via the Janus API, that is the methods for establishing a datachannel-only PeerConnection, and the limited set of synchronous TextRoom requests that are availabie via Janus API as well, rather than datachannel only. Requests that are explicitly only supported when sent on datachannels (e.g., joining a room, sending and receiving messages, etc.) are not covered by this module, and are left entirely to the application layer, as they require access to the datachannel for the purpose.
This should address #33, and from my limited testing seems to be working as expected.