fix: expand memory before slicing initcode in CREATE2 wrapper #296
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Review: LGTM The fix is correct and well-tested. A few notes from the review: Correctness
Tests The three tests cover the three important scenarios cleanly: no panic, correct accounting on success, and correct skip on OOG. The No issues to block merge. |
Troublor
approved these changes
May 11, 2026
flyq
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #293 onto main. Same diff, same intent — bringing the CREATE2 memory-expansion fix into the active development line. #293 was originally merged onto release-v1.5.2 (based on v1.5.1), this PR carries it forward without the 1.5.2 bump or other release-branch commits.