Skip to content

make fx_hashmap_serde public for downstream reuse#133

Merged
flyq merged 2 commits into
mainfrom
liquan/pub_fx_hashmap_serde
May 13, 2026
Merged

make fx_hashmap_serde public for downstream reuse#133
flyq merged 2 commits into
mainfrom
liquan/pub_fx_hashmap_serde

Conversation

@flyq
Copy link
Copy Markdown
Member

@flyq flyq commented May 13, 2026

Summary

  • Promote the fx_hashmap_serde helper module in salt/src/proof/prover.rs from private to pub, and re-export it from salt::proof and the crate root.
  • Convert the explanatory block comment into a doc comment and note that downstream crates (e.g. stateless-core::LightWitness) can now reuse the helper via #[serde(with = "salt::fx_hashmap_serde")].

Why

The hand-written serde helper exists so salt doesn't have to enable hashbrown/serde (which transitively pulls in serde_core 1.0.221+ and breaks alloy-tx-macros 1.0.23). Downstream crates hit the same constraint when serializing FxHashMap fields, so re-exporting the helper lets them apply the same workaround instead of reinventing it or re-introducing the broken transitive dep.

Test plan

  • cargo build -p salt
  • cargo test -p salt
  • Verify a downstream consumer can reference salt::fx_hashmap_serde in #[serde(with = ...)]

@flyq flyq changed the title interface: make fx_hashmap_serde public for downstream reuse make fx_hashmap_serde public for downstream reuse May 13, 2026
@flyq flyq requested review from Troublor, abelmega, Copilot and deepld and removed request for Copilot May 13, 2026 01:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Performance Benchmark Comparison

Compared 5 benchmark(s) against the latest main baseline.

Detailed Comparison
Benchmark Baseline Throughput (Kelem/s) New Throughput (Kelem/s) Change
update 10000 KVs/1 threads 43.52 42.71 -1.85%
update 10000 KVs/2 threads 80.63 80.21 -0.52%
update 10000 KVs/4 threads 149.17 147.63 -1.03%
update 10000 KVs/8 threads 262.18 260.84 -0.51%
update 10000 KVs/16 threads 391.49 390.86 -0.16%

@flyq flyq requested a review from yilongli May 13, 2026 01:51
@flyq flyq merged commit a046470 into main May 13, 2026
13 checks passed
@flyq flyq deleted the liquan/pub_fx_hashmap_serde branch May 13, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants