chore: remove legacy STATELESS_VALIDATOR_LOG_* env var migration#127
Conversation
|
The PR currently has no labels, but it looks like at least the There is no "breaking-change" label available in this repo, but it may be worth noting that the PR description itself flags this as a breaking change (users must rename |
|
LGTM. Clean removal of the migration shim, README updated correctly, breaking change clearly documented. No issues. |
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM. Clean removal — no dangling references remain, the README is updated, and the breaking change is clearly called out in the description. |
Summary
migrate_legacy_env_vars()shim instateless-common::loggingthat copiedSTATELESS_VALIDATOR_LOG_*into the newerSTATELESS_LOG_*names at startup.bin/stateless-validator/src/app.rs::run()and its import.README.mdso the Logging Configuration section documents only the canonicalSTATELESS_LOG_FILE_DIRECTORY/STATELESS_LOG_FILE/STATELESS_LOG_STDOUTvariables.The legacy names duplicated the new ones and were only kept as a transitional alias; with the rename settled, the migration helper is no longer needed.
Breaking change
Users still setting
STATELESS_VALIDATOR_LOG_FILE_DIRECTORY,STATELESS_VALIDATOR_LOG_FILE, orSTATELESS_VALIDATOR_LOG_STDOUTmust rename them to theSTATELESS_LOG_*equivalents. Command-line flags (--log-*) are unchanged.Test plan
cargo build/cargo check --workspacecargo fmt --all --checkandcargo clippy --workspace --all-targets --all-featuresstateless-validatorwithSTATELESS_LOG_FILE_DIRECTORY=./validator-data/logs STATELESS_LOG_STDOUT=infoand confirm file + stdout logging behave as before.STATELESS_VALIDATOR_LOG_*names and confirm they are now ignored (no silent fallthrough).