Skip to content

chore: remove legacy STATELESS_VALIDATOR_LOG_* env var migration#127

Merged
flyq merged 2 commits into
mainfrom
liquan/delete_repeat_log_env
Apr 29, 2026
Merged

chore: remove legacy STATELESS_VALIDATOR_LOG_* env var migration#127
flyq merged 2 commits into
mainfrom
liquan/delete_repeat_log_env

Conversation

@flyq
Copy link
Copy Markdown
Member

@flyq flyq commented Apr 27, 2026

Summary

  • Drop the migrate_legacy_env_vars() shim in stateless-common::logging that copied STATELESS_VALIDATOR_LOG_* into the newer STATELESS_LOG_* names at startup.
  • Remove the corresponding call in bin/stateless-validator/src/app.rs::run() and its import.
  • Update README.md so the Logging Configuration section documents only the canonical STATELESS_LOG_FILE_DIRECTORY / STATELESS_LOG_FILE / STATELESS_LOG_STDOUT variables.

The legacy names duplicated the new ones and were only kept as a transitional alias; with the rename settled, the migration helper is no longer needed.

Breaking change

Users still setting STATELESS_VALIDATOR_LOG_FILE_DIRECTORY, STATELESS_VALIDATOR_LOG_FILE, or STATELESS_VALIDATOR_LOG_STDOUT must rename them to the STATELESS_LOG_* equivalents. Command-line flags (--log-*) are unchanged.

Test plan

  • cargo build / cargo check --workspace
  • cargo fmt --all --check and cargo clippy --workspace --all-targets --all-features
  • Run stateless-validator with STATELESS_LOG_FILE_DIRECTORY=./validator-data/logs STATELESS_LOG_STDOUT=info and confirm file + stdout logging behave as before.
  • Run with the old STATELESS_VALIDATOR_LOG_* names and confirm they are now ignored (no silent fallthrough).

@claude
Copy link
Copy Markdown

claude Bot commented Apr 27, 2026

The PR currently has no labels, but it looks like at least the documentation label is missing — the diff includes updates to README.md (the Logging Configuration section was revised to reflect the canonical STATELESS_LOG_* variable names).

There is no "breaking-change" label available in this repo, but it may be worth noting that the PR description itself flags this as a breaking change (users must rename STATELESS_VALIDATOR_LOG_* env vars). If such a label exists or is created, it would apply here too.

@claude
Copy link
Copy Markdown

claude Bot commented Apr 27, 2026

LGTM. Clean removal of the migration shim, README updated correctly, breaking change clearly documented. No issues.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.9%. Comparing base (686f3ba) to head (a02f752).
⚠️ Report is 1 commits behind head on main.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@claude
Copy link
Copy Markdown

claude Bot commented Apr 27, 2026

LGTM. Clean removal — no dangling references remain, the README is updated, and the breaking change is clearly called out in the description.

@flyq flyq merged commit c07fcce into main Apr 29, 2026
21 checks passed
@flyq flyq deleted the liquan/delete_repeat_log_env branch April 29, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants