Skip to content

fix popover effect when host is not connected to the document #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ocavue wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix popover effect when host is not connected to the document #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/melt/src/lib/builders/Popover.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,15 @@ export class BasePopover {
const isVisible = $derived(this.open || this.forceVisible);
$effect(() => {
const el = document.getElementById(this.ids.popover);
// Ensure Svelte runes effect is triggered even if
// `el` is not found in the first render.
const visible = isVisible;

if (!isHtmlElement(el)) {
return;
}

if (isVisible) {
if (visible) {
return autoOpenPopover({ el });
} else {
safelyHidePopover(el);
Expand Down