Open
Conversation
…object map is its own function
…into feature/agnosis
…into feature/agnosis
…for is-new label only
…ks on everything in translator grammar
… into, and created a generic intInput function
…into feature/agnosis
…ll backwards now (backtrack still exist for the easter egg)
…-umn/silver into feature/agnosis
…ll matthews changes
…into feature/agnosis
…into feature/agnosis
… and some comments have been added to each
…LHS data, old functions removed
…into feature/agnosis
krame505
requested changes
May 8, 2024
| @@ -0,0 +1,27 @@ | |||
| package common; | |||
Member
There was a problem hiding this comment.
Debugger-specific files should be moved to runtime/java/src/common/agnosis/
|
|
||
| //More detailed information about specific calls | ||
| else if(userInputList.length == 2){ | ||
| if(userInputList[1].equals("up")){ |
Member
There was a problem hiding this comment.
Could be cleaner as a switch statement.
| private String[] toggleChoices; | ||
|
|
||
| private boolean isRoot(DecoratedNode dn) { | ||
| return |
| } | ||
|
|
||
| //Replaces currentNode with its parent | ||
| public Integer up() |
Member
There was a problem hiding this comment.
Is there a reason these functions return Integer instead of int?
| String[] attributeArrayView = attributeListView.toArray(new String[attributeListView.size()]); | ||
| System.out.println("Which attribute?"); | ||
| displayArray(attributeArrayView); | ||
| System.out.print(">DEBUGGER-PROMPT$"); |
Member
There was a problem hiding this comment.
It's a bit confusing that the prompt is the same for choosing the attribute. Could just have "Which attribute? " as the prompt.
| @@ -0,0 +1,71 @@ | |||
| # agnosis README | |||
Member
There was a problem hiding this comment.
Remove or update this template README file?
| @@ -0,0 +1,43 @@ | |||
| # Welcome to your VS Code Extension | |||
Member
There was a problem hiding this comment.
Remove or update this template file?
| "request": "launch", | ||
| "args": [ | ||
| "--extensionDevelopmentPath=${workspaceFolder}", | ||
| "--folder-uri=file:///home/tardis/Documents/example_expr_translator-main/translator" |
| @@ -0,0 +1,87 @@ | |||
| //package agnosis-context.libs.visualization; | |||
Member
There was a problem hiding this comment.
This class doesn't seem to be used anywhere - remove? Seems redundant with Location anyway.
| } | ||
|
|
||
| } | ||
| //TODO: Add way to access children names |
added 2 commits
May 8, 2024 20:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Base implementation of debugger for Silver
Documentation
Testing