Add offline e2e script checks - #262
Closed
okJiang wants to merge 1 commit into
Closed
Conversation
👷 Deploy request for mem9 pending review.A Netlify team Owner will need to approve the deploy before you can run your build. Are you a team Owner? Visit the deploys page to approve it → Need more help? Learn more in the Netlify docs →
|
okJiang
commented
Apr 22, 2026
okJiang
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM. Minimal offline guardrail — well-scoped first tier.
Contributor
Author
|
Closing this PR based on the review discussion. The standalone offline e2e script guardrail is too narrow to justify an additional CI workflow, and it does not validate Mem9 API behavior. We will keep the current automation focus on the local server smoke coverage in #263, which runs a real |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make e2e-checkfor offline validation ofe2escripts.e2e/README.md.Details
The new guardrail checks shell syntax,
set -euo pipefail, Python syntax viacompile(...), and the v1alpha2 wrapper script targets. It intentionally does not call any Mem9 API or live backend.Validation
make e2e-checkmake test-cover