Skip to content

Add offline e2e script checks - #262

Closed
okJiang wants to merge 1 commit into
mainfrom
at-kay/e2e-local-guardrails
Closed

Add offline e2e script checks#262
okJiang wants to merge 1 commit into
mainfrom
at-kay/e2e-local-guardrails

Conversation

@okJiang

@okJiang okJiang commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add make e2e-check for offline validation of e2e scripts.
  • Add a PR/push/manual GitHub Actions workflow that runs the guardrail without requiring dev/staging, secrets, or network access.
  • Document the offline guardrail in e2e/README.md.

Details

The new guardrail checks shell syntax, set -euo pipefail, Python syntax via compile(...), and the v1alpha2 wrapper script targets. It intentionally does not call any Mem9 API or live backend.

Validation

  • make e2e-check
  • make test-cover

@netlify

netlify Bot commented Apr 22, 2026

Copy link
Copy Markdown

👷 Deploy request for mem9 pending review.

A Netlify team Owner will need to approve the deploy before you can run your build.

Are you a team Owner? Visit the deploys page to approve it

Need more help? Learn more in the Netlify docs

Name Link
🔨 Latest commit f7ff3f7

@okJiang okJiang left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minimal offline guardrail — well-scoped first tier.

@okJiang

okJiang commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing this PR based on the review discussion. The standalone offline e2e script guardrail is too narrow to justify an additional CI workflow, and it does not validate Mem9 API behavior. We will keep the current automation focus on the local server smoke coverage in #263, which runs a real mnemo-server with local pgvector and validates API behavior without dev/staging dependencies.

@okJiang okJiang closed this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant