Skip to content

Line Position Update #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamseeley merged 2 commits into from
Jan 26, 2026
Merged

Line Position Update #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9bcf01
line positions only for visible lines, remove logs
iamseeley Jan 26, 2026
1693bae
remove comments
iamseeley Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/vs/workbench/contrib/membrane/browser/membraneEditorDecorations.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,6 @@ export class MembraneEditorDecorationsContribution extends Disposable implements
private _createViewZoneNode(zone: IMembraneViewZone, fontInfo: { fontFamily: string; fontSize: number; lineHeight: number }): HTMLElement {
const container = document.createElement('div');

console.log('[membrane] fontInfo:', fontInfo.fontFamily, fontInfo.fontSize, fontInfo.lineHeight);


if (zone.styled) {
// Styled view zone (e.g., deleted lines in diff)
container.style.cssText = `
Expand Down
18 changes: 13 additions & 5 deletions src/vs/workbench/contrib/membrane/browser/membraneEditorMetrics.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,21 @@ export class MembraneEditorMetricsContribution extends Disposable implements IWo
const startLine = Math.max(1, firstVisibleLine - 20);
const endLine = Math.min(lineCount, lastVisibleLine + 20);

const isLineVisible = (line: number): boolean => {
return visibleRanges.some(range =>
line >= range.startLineNumber && line <= range.endLineNumber
);
};

const linePositions: Array<{ line: number; top: number; bottom: number }> = [];
for (let line = startLine; line <= endLine; line++) {
linePositions.push({
line,
top: editor.getTopForLineNumber(line, true),
bottom: editor.getBottomForLineNumber(line),
});
if (isLineVisible(line)) {
linePositions.push({
line,
top: editor.getTopForLineNumber(line, true),
bottom: editor.getBottomForLineNumber(line),
});
}
}

return {
Expand Down
Loading