Conversation
FelonEkonom
reviewed
Mar 26, 2026
Member
FelonEkonom
left a comment
FelonEkonom
left a comment
There was a problem hiding this comment.
Have you thought about adding option to disable the new warning? E.g. via config env or use opts. Especially when we count all redemands, instead of counting them separately for each pad. On the other hand, I maybe it is an overkill to add a big option just for a one, tiny, little warning 🤔
| if type == :sink do | ||
| raise ActionError, action: action, reason: {:invalid_element, type} | ||
| else | ||
| state = %{state | uninterrupted_redemands: 0} |
Member
There was a problem hiding this comment.
What about keeping a separate counter for each pad?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.