Draft
Conversation
Specifically, cleaning up gcov's and gcovr's files and making sure the coverage run has the build type set to `TEST`.
Also, replaced occurrences of `ccol` /w `conficol`.
1. Accidentally kept the seed value a `uint8_t` even when shifting it left however many bits past 8... 2. Unused leftover `prn` var in `for` loop
New design philosophy - security over convenience.
``` gcc -Og -g3 -std=c23 -Wall -Wextra -Wpedantic --pedantic-errors -Iinc/ -Isubmodules/ -o build/test_conficol_shared.exe src/conficol_shared.c test/test_conficol_shared.c -lunity ```
Test rules also in-place but I need to work out how to get `Unity` back in as a submodule and have it not clash /w the system-wide unity files I've installed for w64devkit...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Project Planning Tool User Story / Defect Number | Issue
Verification
Unit Tests
HIL Tests (if applicable)
System Tests
Device Verification
Validation
End-User Testing
Statistics
Microcontroller Stats
Communication Bus Network Stats
Upstream / Downstream Repositories
Requirements
Quality Checklist
CHANGELOG.mdhas been updatedREADME.mdhas been updated if applicable