Skip to content

chore: remove language selector#2288

Open
r0b1n wants to merge 1 commit into
mainfrom
chore/remove-language-selector
Open

chore: remove language selector#2288
r0b1n wants to merge 1 commit into
mainfrom
chore/remove-language-selector

Conversation

@r0b1n

@r0b1n r0b1n commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This package is replaced by combobox in both version of atlas core.

@r0b1n r0b1n requested a review from a team as a code owner June 23, 2026 11:31
iobuhov
iobuhov previously approved these changes Jun 23, 2026
@github-actions

This comment has been minimized.

leonardomendix
leonardomendix previously approved these changes Jun 23, 2026
@r0b1n r0b1n dismissed stale reviews from leonardomendix and iobuhov via 3597624 June 23, 2026 12:33
@r0b1n r0b1n force-pushed the chore/remove-language-selector branch from 539afd2 to 3597624 Compare June 23, 2026 12:33
@github-actions

This comment has been minimized.

# Conflicts:
#	pnpm-lock.yaml
@r0b1n r0b1n force-pushed the chore/remove-language-selector branch from 3597624 to eb5c5ee Compare June 24, 2026 09:31
@github-actions

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found


What was reviewed

File Change
.github/configs/labeler.yml Removed language-selector-web label rule
packages/pluggableWidgets/language-selector-web/** Entire package deleted (source, XML, SCSS, tests, e2e, assets, typings, config)
pnpm-lock.yaml Lockfile updated to reflect package removal

Skipped (out of scope): pnpm-lock.yaml (lockfile-only changes)


Positives

  • Complete and clean removal — every file in the package directory deleted, no orphaned references left anywhere in the repo
  • Labeler configuration updated in lockstep with the package deletion, preventing stale label-matching rules
  • Workspace config uses a packages/*/* glob so no explicit exclusion was needed — the removal is automatically effective
  • PR title follows conventional commits (chore:) and the description clearly states the replacement (combobox widget in Atlas core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants