You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
⚠️ Approved with suggestions — low-severity items only, safe to merge
What was reviewed
File
Change
packages/modules/data-widgets/CHANGELOG.md
Added Fixed entry under [Unreleased] for Dojo client compatibility
patches/@mendix__pluggable-widgets-tools.patch
Bumped Babel @babel/preset-env target from safari: "12" to safari: "16.3" in two places in configs/rollup.config.mjs
Skipped (out of scope): pnpm-lock.yaml
Findings
⚠️ Low — Safari minimum support implication not documented
File:patches/@mendix__pluggable-widgets-tools.patch lines 32–42 Note: Bumping the Babel target from safari: "12" (2018) to safari: "16.3" (Feb 2023) silently raises the minimum supported Safari version for all built widgets. This prevents Babel from emitting helpers that break the Dojo client — which is the correct fix — but it's worth confirming this aligns with Mendix's official minimum browser support policy. Safari 12–16.2 users would receive a bundle without the polyfills Babel previously generated for them. If that range is still in scope, a note in the patch or commit message explaining the trade-off would help future reviewers.
Positives
Correct use of the pnpm patch mechanism: the vendor package is modified without forking, and the lockfile patch hash is updated consistently across all importer entries.
CHANGELOG entry describes the user-visible symptom ("Data Widgets not working in Dojo client") rather than the implementation detail, matching repo convention.
Both Babel config sites in configs/rollup.config.mjs (the ES module path and the CommonJS path) are updated together — no missed occurrence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.