Skip to content

chore: bump babel targets to prevent inclusion of helpers#2291

Merged
r0b1n merged 2 commits into
mainfrom
chore/update-babel-target
Jun 24, 2026
Merged

chore: bump babel targets to prevent inclusion of helpers#2291
r0b1n merged 2 commits into
mainfrom
chore/update-babel-target

Conversation

@r0b1n

@r0b1n r0b1n commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@r0b1n r0b1n requested a review from a team as a code owner June 24, 2026 15:29
@github-actions

This comment has been minimized.

iobuhov
iobuhov previously approved these changes Jun 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

AI Code Review

⚠️ Approved with suggestions — low-severity items only, safe to merge


What was reviewed

File Change
packages/modules/data-widgets/CHANGELOG.md Added Fixed entry under [Unreleased] for Dojo client compatibility
patches/@mendix__pluggable-widgets-tools.patch Bumped Babel @babel/preset-env target from safari: "12" to safari: "16.3" in two places in configs/rollup.config.mjs

Skipped (out of scope): pnpm-lock.yaml


Findings

⚠️ Low — Safari minimum support implication not documented

File: patches/@mendix__pluggable-widgets-tools.patch lines 32–42
Note: Bumping the Babel target from safari: "12" (2018) to safari: "16.3" (Feb 2023) silently raises the minimum supported Safari version for all built widgets. This prevents Babel from emitting helpers that break the Dojo client — which is the correct fix — but it's worth confirming this aligns with Mendix's official minimum browser support policy. Safari 12–16.2 users would receive a bundle without the polyfills Babel previously generated for them. If that range is still in scope, a note in the patch or commit message explaining the trade-off would help future reviewers.


Positives

  • Correct use of the pnpm patch mechanism: the vendor package is modified without forking, and the lockfile patch hash is updated consistently across all importer entries.
  • CHANGELOG entry describes the user-visible symptom ("Data Widgets not working in Dojo client") rather than the implementation detail, matching repo convention.
  • Both Babel config sites in configs/rollup.config.mjs (the ES module path and the CommonJS path) are updated together — no missed occurrence.

@r0b1n r0b1n merged commit 997f864 into main Jun 24, 2026
11 of 14 checks passed
@r0b1n r0b1n deleted the chore/update-babel-target branch June 24, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants