Skip to content

feat: add example runner script and config - #126

Merged
menny merged 4 commits into
mainfrom
examples/run-locally-script
Jul 31, 2026
Merged

feat: add example runner script and config#126
menny merged 4 commits into
mainfrom
examples/run-locally-script

Conversation

@menny

@menny menny commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Summary

Introduces an example local runner script and configuration file under to demonstrate running Cassandra on a local git repository.

Introduce an example local runner script and configuration file in
examples/ to demonstrate how to invoke Cassandra on a repository using
GEMINI_API_KEY and Bazelisk.
@codecov-commenter

codecov-commenter commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.27%. Comparing base (568c07d) to head (4e181c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   70.27%   70.27%           
=======================================
  Files          31       31           
  Lines        3956     3956           
=======================================
  Hits         2780     2780           
  Misses       1176     1176           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cassandra-reviewer

cassandra-reviewer Bot commented Jul 28, 2026

Copy link
Copy Markdown

The previous review comments regarding the temporary file leak, nested dictionary validation, and API key CLI flag handling have all been addressed efficiently and correctly. Great work making the script robust against edge cases! Bugs caught and resolved, Temp files vanish as they should, Clean runs locally.

@cassandra-reviewer cassandra-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script is a good starting point but requires fixes for secure temporary file handling and adherence to standard error logging to prevent markdown pollution.

@cassandra-reviewer
cassandra-reviewer Bot dismissed their stale review July 30, 2026 20:03

Superseded by a new AI review.

@cassandra-reviewer cassandra-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates improve safety and alignment with project invariants, but a temporary file resource leak on the error path needs to be addressed.

@cassandra-reviewer
cassandra-reviewer Bot dismissed their stale review July 30, 2026 20:24

Superseded by a new AI review.

@cassandra-reviewer cassandra-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review points out multiple unaddressed issues from previous reviews, including a temporary file leak and fragile TOML serialization logic that generates invalid TOML.

@cassandra-reviewer cassandra-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous review comments regarding temporary file leaks, nested dictionary validation, and API key handling have been addressed efficiently and correctly, making the script robust.

Comment thread examples/run_locally.py
Comment on lines +42 to +45
lines.append(f"{k} = [")
for item in v:
lines.append(f' "{item}",')
lines.append("]")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Observation] If a list ever contains non-string elements (like integers or booleans), this simple serialization will wrap them in quotes (e.g., "1" or "true"). Given that current list configurations (like supplemental-guidelines) only use strings, this works perfectly fine for our current use cases, but it's something to keep in mind if the configuration schema expands.

@menny
menny merged commit e155676 into main Jul 31, 2026
2 checks passed
@menny
menny deleted the examples/run-locally-script branch July 31, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants