Conversation
There was a problem hiding this comment.
Stale comment
This PR switches CELO mock funding in
SetupForkfromdealFork(..., true)to explicitmint()calls, and refactorsWeekendSituationTestto avoid repeated local casting of the factory.Findings
test/integration/WeekendSituationTest.t.sol
- 🔴 Critical —
L35,L42,L54:fpmmFactoryis declared asaddressinV3IntegrationBase, but this PR treats it asIFPMMFactory. This introduces a compile-time regression (member deployedFPMMAddresses not found in address) and blocks the test suite.Suggested fix (pick one):
// Option A: keep base state var as address and cast locally fpmmFactory = lookupProxyOrFail("FPMMFactory"); ... IFPMMFactory factory = IFPMMFactory(fpmmFactory); address[] memory fpmms = factory.deployedFPMMAddresses();// Option B: change base type once (broader impact) IFPMMFactory internal fpmmFactory;Final verdict: 🚫 Needs changes
Sent by Cursor Automation: PR Review
There was a problem hiding this comment.
Stale comment
This PR switches fork CELO funding from
dealFork(...)to explicitmint()on the etchedMockCELO, removes localfpmmFactoryshadowing in weekend integration tests, and updatesfoundry.lockrevisions.
test/integration/WeekendSituationTest.t.sol
- 🔴 CRITICAL
line 35(with downstream impact atlines 42and54):fpmmFactoryis inherited fromV3IntegrationBaseasaddress, but this change treats it asIFPMMFactoryand then callsfpmmFactory.deployedFPMMAddresses(). This is a type-level regression that will fail compilation (Member "deployedFPMMAddresses" not found in address).- Fix by either:
- Keeping
fpmmFactoryasaddressand using a non-shadowing local typed alias (e.g.IFPMMFactory factory = IFPMMFactory(fpmmFactory);), or- Promoting the base-state variable type to
IFPMMFactoryconsistently where it is declared and consumed.Final verdict: 🚫 Needs changes
Sent by Cursor Automation: PR Review
There was a problem hiding this comment.
This PR replaces the CELO fork funding path in SetupFork to use mint() on the etched mock token and cleans up the FPMM factory access pattern in the weekend integration test. The changes are small, targeted, and aligned with the PR goal.
No findings.
Final verdict: ✅ LGTM
Sent by Cursor Automation: PR Review
philbow61
left a comment
There was a problem hiding this comment.
For me, the SetupFork script is still failing on celo mainnet?


dealFork was failing for mock Celo because foundry couldn't find the storage slot for some reason. This PR uses the
mint()function on Celo insteadAlso: fixed a variable name shadowing in a test