Fix: RAM-based secrets injection + config save encryption#149
Merged
Conversation
- ConfigSave now re-encrypts .env files before commit when deployment.secrets is set to 'encrypted', so config save actually pushes updated .env.enc - ProtocolStart no longer copies secrets to disk; passes /dev/shm path directly to Docker Compose override, keeping secrets RAM-only - SecretsProvider uses absolute paths in env_file override so Docker can read from /dev/shm - Added debug logging to SecretsProvider for troubleshooting secrets resolution Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.envfiles before committing whendeployment.secrets = 'encrypted', fixing the bug whereconfig savepushed stale.env.enc/dev/shm(RAM) and passes absolute paths to the Docker Compose overrideenv_fileoverride YAML so Docker can read from/dev/shm, and adds debug logging to/var/log/protocol/secrets-provider.logfor troubleshootingTest plan
protocol config savewithdeployment.secrets = 'encrypted'— verify.env.encis updated in gitprotocol startwithdeployment.secrets = 'aws'— verifydocker exec <container> envshows AWS secrets.env.protocol-secretsfile is written to the project directory/var/log/protocol/secrets-provider.logfor debug output🤖 Generated with Claude Code