Open
Conversation
I want the same variable name to mean the same thing everywhere in my code. It makes it easier to read the code later.
yarikoptic
reviewed
Mar 13, 2019
Contributor
yarikoptic
left a comment
yarikoptic
left a comment
There was a problem hiding this comment.
seems to be looking neat, but have no clue if works correctly - not a single test?
| key.append(0) | ||
| key.append(-2) | ||
| else: | ||
| key.append(int(trl_dat[4])) |
Contributor
There was a problem hiding this comment.
thiis quite cryptic , e.g. why 0 was incorrect and -2 is so much better etc.... leave comments for yourself so later on you could figure out why you did it this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want the same variable name to mean the same thing everywhere in my code. It makes it easier to read the code later.