fix: support Windows host runtimes and stable native caching#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix Windows native addon loading under compatible Node-API host runtimes and prevent stale vcpkg caches from rebuilding OpenSSL on every CI run.
Root cause
The addon linked delayed
node.exeimports but omitted${CMAKE_JS_SRC}. Under Bun on Windows, the first Node-API call could cross into a separately loaded Node runtime and crash the process. The standard cmake-jswin_delay_load_hook.ccredirects those imports to the active host runtime.Windows CI also cached
vcpkg_installedunder a key that ignored the MSVC toolset. GitHub Actions could restore an ABI-incompatible exact cache, vcpkg would remove and rebuild OpenSSL, and the immutable cache entry could not be replaced.Changes
${CMAKE_JS_SRC}to the native addon target.Impact
Validation
npm run buildnpm run checknpm run native:checknpm test(52/52)git diff --check