feat: add typed libdatachannel extensions#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Expose a narrow typed
nonstandardsurface for libdatachannel capabilities while preserving the existing W3C-facingRTCPeerConnection,RTCDataChannel, andsetLocalDescription()behavior.Changes
nonstandard.IceUdpMuxListenerbacked byrtc::IceUdpMuxListenerrtc::LocalDescriptionInitRTCCertificateBehavior impact
The standard WebRTC facade remains unchanged unless a
nonstandardextension is explicitly used. Fingerprint verification stays enabled by default. Explicit ICE credentials preserve browser-shaped local description, signaling, gathering, and event timing until standardsetLocalDescription()is called.Native impact
The addon remains Node-API-only. UDP mux callbacks are delivered through a
Napi::ThreadSafeFunction; repeated close, garbage collection, late queued callbacks, and environment shutdown are handled explicitly.WPT and browser impact
No WPT selection or expected result classification changes. Local validation passed:
npm run checknpm run native:checknpm run buildnpm test(63/63)npm run api:checknpm run types:checknpm run pack:checknpm run wpt:selection:checknpm run wpt:smokeandnpm run wpt:smoke:check(4/4, no retries)npm run e2e:chrome(12/12 scenarios)The full selected WPT suite is delegated to the branch Conformance workflow.