Merged
Conversation
This seems to fix compilation errors that currently break the tests.
See mesh-adaptation/docs#156. This PR adds a separate test suite workflow for the new `release` branch. That test suite not only runs on Animate's `release` branch, but also with the `release` version of Firedrake.
Closes #225. Moves `to_petsc_local_numbering` to Animate and adds a basic unit test.
joewallwork
moved this from In Progress
to Ready for review
in Mesh Adaptation development board
stephankramer
approved these changes
Mar 2, 2026
Collaborator
stephankramer
left a comment
stephankramer
left a comment
There was a problem hiding this comment.
This is great, good to finally have this working! Changes all make sense.
github-project-automation
bot
moved this from Ready for review
to Ready to merge
in Mesh Adaptation development board
github-project-automation
bot
moved this from Ready to merge
to Done
in Mesh Adaptation development board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: merges into
releaserather thanmain.This PR aims to get the
releasebranch working. This requires:topological_dimensionandgeometric_dimensionmethods rather than properties.It also pulls in some recent changes from Animate
main.