Skip to content

Allow Cython build #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joewallwork merged 3 commits into from
Feb 23, 2026
Merged

Allow Cython build #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4e220b
Allow pip cache to be editable in Docker image
joewallwork Feb 20, 2026
95d4b73
Allow passing Docker tag to Makefile
joewallwork Feb 20, 2026
18937d5
Pip install with --no-build-isolation
joewallwork Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reusable_test_suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
git submodule init
git submodule update
pip uninstall ${REPO_NAME} -y || true
pip install -e .[dev]
pip install --no-build-isolation .[dev]

- run: make lint

Expand Down
3 changes: 3 additions & 0 deletions docker/Dockerfile.firedrake-parmmg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ ARG BRANCH="main"

WORKDIR /root

# Ensure /github/home/.cache/pip is editable by the user
RUN mkdir -p /github/home/.cache/pip && chmod -R 777 /github/home/.cache/pip

# Install Thetis
RUN pip install --verbose --src . -e git+https://github.com/thetisproject/thetis.git#egg=thetis

Expand Down
3 changes: 3 additions & 0 deletions docker/Dockerfile.firedrake-parmmg_release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ ARG BRANCH="main"

WORKDIR /root

# Ensure /github/home/.cache/pip is editable by the user
RUN mkdir -p /github/home/.cache/pip && chmod -R 777 /github/home/.cache/pip

# Install Thetis
RUN pip install --verbose --src . -e git+https://github.com/thetisproject/thetis.git#egg=thetis

Expand Down
2 changes: 1 addition & 1 deletion docker/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ PACKAGE ?=
OPTIONS ?=
NAMESPACE = ghcr.io/mesh-adaptation
IMAGE = $(PACKAGE)
TAG = latest
TAG ?=
USERNAME ?=
TOKEN ?=

Expand Down